Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add check for rules docs #3150

Merged
merged 3 commits into from
Jun 10, 2024
Merged

ci: add check for rules docs #3150

merged 3 commits into from
Jun 10, 2024

Conversation

ematipico
Copy link
Member

Summary

This PR restores a script that checks the validity of the docs of our rules. This code was copied from the website repository and stripped of all the logic regarding generating the docs.

Plus, it adds this check inside the CI and gen-lint

Test Plan

CI should pass

@github-actions github-actions bot added the A-Tooling Area: internal tools label Jun 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 50787 50787 0
Passed 49680 49680 0
Failed 1107 1107 0
Panics 0 0 0
Coverage 97.82% 97.82% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6534 6534 0
Passed 2087 2087 0
Failed 4447 4447 0
Panics 0 0 0
Coverage 31.94% 31.94% 0.00%

ts/babel

Test result main count This PR count Difference
Total 667 667 0
Passed 595 595 0
Failed 72 72 0
Panics 0 0 0
Coverage 89.21% 89.21% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 18217 18217 0
Passed 13961 13961 0
Failed 4256 4256 0
Panics 0 0 0
Coverage 76.64% 76.64% 0.00%

@ematipico ematipico merged commit bf5b4dd into main Jun 10, 2024
15 checks passed
@ematipico ematipico deleted the ci/rules-check branch June 10, 2024 08:37
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jun 10, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #3150 will not alter performance

Comparing ci/rules-check (3b62816) with ci/rules-check (ef68ae5)

Summary

✅ 92 untouched benchmarks

@ematipico ematipico mentioned this pull request Jun 10, 2024
Merged
@abdulrahman305 abdulrahman305 mentioned this pull request Jul 2, 2024
Merged
@Conaclos Conaclos added the A-Changelog Area: changelog label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sec-ant Sec-ant Sec-ant left review comments

Assignees
No one assigned
Labels
A-Changelog Area: changelog A-Tooling Area: internal tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ematipico @Sec-ant @Conaclos